[XrdCl] Fix error checking when setting sec.uid, sec.gid #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I was calling setfsuid(-1) to check if the previous call had succeeded, since this syscall will always return the current fsuid, whether the syscall itself succeeded or not. There's no way to check other than calling setfsuid again, since there's no getfsuid. The expectation was that setfsuid(-1) will always fail and not affect the fsuid, effectively acting as getfsuid, but it appears that on SLC6 it succeeds, setting the fsuid to.. 4294967295. On Fedora 26 it fails as expected, I have no idea why there's a difference. Instead, let's use setfsuid(pFsUid) again, just to check if the previous call succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I was calling setfsuid(-1) to check if the
previous call had succeeded, since this syscall will
always return the current fsuid, whether the syscall
itself succeeded or not. There's no way to check
other than calling setfsuid again, since there's no
getfsuid.
The expectation was that setfsuid(-1) will always fail
and not affect the fsuid, effectively acting as getfsuid,
but it appears that on SLC6 it succeeds, setting the
fsuid to.. 4294967295. On Fedora 26 it fails as expected,
I have no idea why there's a difference.
Instead, let's use setfsuid(pFsUid) again, just to
check if the previous call succeeded.