Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the throttle plugin to propogate underlying errors. #781

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

bbockelm
Copy link
Contributor

Make sure to always set the error member appropriately whenever something besides SFS_OK is returned.

Fixes #752

Make sure to always set the error member appropriately whenever
something besides SFS_OK is returned.
@abh3
Copy link
Member

abh3 commented Jul 30, 2018

Hi Brian,

Well, that's 50% of the problem. While the error information is indeed copied back, the callback information and other options are not copied forward. That means all callback are turned off in he subsequent ofs layer. Not something that is a god thing to do for performance. Please take a look at hjow this is done via XrdSsiFile::CopyECB() and when it should be called. Of course, all of this is nonsense and will be trivialized in R5.

@bbockelm
Copy link
Contributor Author

@abh3 - ok, the latest commit copies forward the callbacks in the same manner as SSI.

@abh3
Copy link
Member

abh3 commented Jul 30, 2018

Thanks!

@abh3 abh3 merged commit 9ad5765 into xrootd:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants