Do not increment reqstate when headers are incomplete. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server got incomplete headers (I was able to reliably trigger this with connection reuse), the reqstate variable was still incremented. This resulted in the request state becoming inconsistent - notably, HEAD requests believed they always included a checksum. There are likely other strange XrdHttp behaviors that could have been triggered due to the same bug. (cherry picked from commit 88dad6a)
|
Unfortunately, our HTTP approver is out on vacation until the 22nd. So,
this seems to be a roadblock at this point, sigh.
Andy
…On Wed, 12 Sep 2018, Brian P Bockelman wrote:
If the server got incomplete headers (I was able to reliably trigger this with connection reuse), the `reqstate` variable was still incremented.
This resulted in the request state becoming inconsistent - notably, for master, we saw `HEAD` requests believed they always included a checksum. There are likely other strange XrdHttp behaviors that could have been triggered due to the same bug, hence the request for backport to the stable branch.
(cherry picked from commit 88dad6a; backport of relevant fix in #822)
You can view, comment on, or merge this pull request online at:
#825
-- Commit Summary --
* Do not increment reqstate when headers are incomplete.
-- File Changes --
M src/XrdHttp/XrdHttpProtocol.cc (1)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/825.patch
https://github.com/xrootd/xrootd/pull/825.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#825
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
|
|
Hi Andy, This is simply a backport of #822. We put other (more complex) backports into stable without Fabrizio - why do we need him now? Brian |
|
Hi Brian,
It’s simple professional courtesy. Let me see what I can do.
Andy
From: Brian P Bockelman
Sent: Monday, September 17, 2018 7:28 AM
To: xrootd/xrootd
Cc: xrootd-dev ; Comment
Subject: Re: [xrootd/xrootd] Do not increment reqstate when headers are incomplete. (#825)
Hi Andy,
This is simply a backport of #822. We put other (more complex) backports into stable without Fabrizio - why do we need him now?
Brian
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
…--------------------------------------------------------------------------------
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server got incomplete headers (I was able to reliably trigger this with connection reuse), the
reqstatevariable was still incremented.This resulted in the request state becoming inconsistent - notably, for master, we saw
HEADrequests believed they always included a checksum. There are likely other strange XrdHttp behaviors that could have been triggered due to the same bug, hence the request for backport to the stable branch.(cherry picked from commit 88dad6a; backport of relevant fix in #822)