Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support signing of server DH public parameters #869

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

gganis
Copy link
Member

@gganis gganis commented Dec 7, 2018

Revised version of PR #867

@wyang007
Copy link
Member

wyang007 commented Dec 7, 2018

Hi Gerri,
I will try this out to see how it works. One concern by just looking at the code is that in line 1777, you directly added the signed DH pub pars to the bucket. In my previous test, the bck->buffer sometimes had \0 in the middle, and the receiving end would get this wrong. So I used bytes2hex() (or later Andy's XrdOucac2::b2x()) to convert it to hex string before we send it over the wire. Is this still a concern?

@wyang007
Copy link
Member

wyang007 commented Dec 7, 2018

Forgot another thing: we are asked to turn off delegation if the DH pub pars exchange is not encrypted. Can we also add this in 869?

@wyang007
Copy link
Member

wyang007 commented Dec 7, 2018

So far it works, except the part to disabling proxy delegation when the client talks to a server with older version number.

@abh3 abh3 merged commit dc06e69 into xrootd:master Dec 7, 2018
simonmichal pushed a commit that referenced this pull request Dec 10, 2018
support signing of server DH public parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants