Consolidate padding support detection

[gganis]

Also fixes a compilation issue on SLC6

[xrootd-dev]

Hi Gerri, We can't merge this as it has a compilation error. Failing platforms: gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 clang x86_64-unknown-linux-gnu Please pushthe fix. sslCipher.cc.o /home/travis/build/xrootd/xrootd/src/XrdCrypto/XrdCryptosslCipher.cc: In constructor XrdCryptosslCipher::XrdCryptosslCipher(bool, int, char*, int, const char*): /home/travis/build/xrootd/xrootd/src/XrdCrypto/XrdCryptosslCipher.cc:521:88: error: DH_compute_key_padded was not declared in this scope ltmp = DH_compute_key_padded((unsigned char *)ktmp,bnpub,fDH); /home/travis/build/xrootd/xrootd/src/XrdCrypto/XrdCryptosslCipher.cc: In member function virtual bool XrdCryptosslCipher::Finalize(bool, char*, int, const char*): /home/travis/build/xrootd/xrootd/src/XrdCrypto/XrdCryptosslCipher.cc:695:76: error: DH_compute_key_padded was not declared in this scope ltmp = DH_compute_key_padded((unsigned char *)ktmp,bnpub,fDH); make[2]: *** [src/CMakeFiles/XrdCryptossl-4.dir/XrdCrypto/XrdCryptosslCipher.cc.o] Error 1 make[1]: *** [src/CMakeFiles/XrdCryptossl-4.dir/all] Error 2 make: *** [all] Error 2 The command "make" exited with 2.

…

On Sun, 16 Dec 2018, Gerardo GANIS wrote: Also fixes a compilation issue on SLC6 You can view, comment on, or merge this pull request online at: #882 -- Commit Summary -- * FindOpenSSL: add check for DH_compute_key_padded * sslCipher: remove local definition of DH_compute_key_padded * sslFactory: consolidate HasPaddingSupport using the result of FindOpenSSL * sslCipher: remove unnecessary unorthodox constructor -- File Changes -- M cmake/FindOpenSSL.cmake (9) M src/XrdCrypto/XrdCryptosslCipher.cc (16) M src/XrdCrypto/XrdCryptosslCipher.hh (2) M src/XrdCrypto/XrdCryptosslFactory.cc (6) -- Patch Links -- https://github.com/xrootd/xrootd/pull/882.patch https://github.com/xrootd/xrootd/pull/882.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #882 ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1