OAuth2-based Macaroon acquisition #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal is to allow someone to request a macaroon via a standard OAuth2 client credential workflow.
| return req.SendSimpleResp(400, NULL, NULL, "Invalid grant type specified.", 0); | ||
| } | ||
| } | ||
| else if (key == "expire_in") |
There was a problem hiding this comment.
this "expire_in" grant parameter (which I guess is used to limit the access token lifetime) is something where we want to be aligned, or FTS will have to juggle. StoRM uses the 'lifetime' parameter. No problem to change on our side, but I suggest to have a profile document that defines these details somewhere and align implementations to such profile.
There was a problem hiding this comment.
Yes - this was a bit arbitrary on my part. I didn't know of an "obvious" candidate here.
Any reason that expires_in versus expire_in versus lifetime might be preferred? Shall we start flipping coins?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the OAuth 2.0 client credentials workflow for acquiring a macaroon. This provides a more standards-based approach to token acquisition compared to the existing method developed by @paulmillar, which has served us well but is admittedly a bit more ad-hoc. With this PR, both the old method and new method ought to work.
This approach was originally implemented in StoRM by @andreaceccanti. I wanted to have a second server implementation prior to doing the client side changes for FTS.
This is NOT meant for 4.9.0.