[XrdMacaroons] Fix default for macaroons.onmissing
#945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, if the `onmissing` parameter is not set, it results in undefined behavior. Works on developer testbeds, blows up in production. Issue originally reported by John Thiltges.
This commit prevents a potential read of uninitialized bytes (not triggered under normal circumstances but flagged by valgrind) and ensures that we free the resulting JSON object.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing 4.9.1-rc1, @jthiltges reported that
macaroons.onmissinghad undefined behavior if it was not set in the configuration file (unfortunately, the undefined behavior for my test platforms was the same as the expected behavior ... but not in production!).Since I was hitting the codebase with valgrind, this PR also fixes two minor memory leaks and one uninitialized read.
@simonmichal - please backport for 4.9.1 final!