Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XrdHttp] Don't add blank header if m_digest_header is empty #949

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

jthiltges
Copy link
Contributor

Testing 4.9.1-rc2, @matyasselmeci noted that HTTP output prepends a \r\n to the expected contents.

@bbockelm was able to isolate the issue and suggested the patch in this PR.

This would be helpful to have in RC3. @simonmichal

Example:
xrootd-4.9.1-0.1.rc1.osg34.el7.x86_64

$ curl -s -k -E /tmp/cert.pem 'https://xrootd.example.edu:1094/hello_world.txt' | hexdump -C
00000000  68 65 6c 6c 6f 20 77 6f  72 6c 64 21 0a           |hello world!.|
0000000d

xrootd-4.9.1-0.2.rc2.osg34.el7.x86_64

$ curl -s -k -E /tmp/cert.pem 'https://xrootd.example.edu:1094/hello_world.txt' | hexdump -C
00000000  0d 0a 68 65 6c 6c 6f 20  77 6f 72 6c 64           |..hello world|
0000000d

@bbockelm bbockelm mentioned this pull request Mar 28, 2019
@ffurano ffurano merged commit c7ad6a0 into xrootd:master Mar 28, 2019
@jthiltges jthiltges deleted the http-crlf branch June 25, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants