Include provided opaque information in the redirection #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes the opaque information provided in the URL; for example, if the `Authorization` header is added to the XRootD CGI as `authz`, then this will now be included in the redirection.
With this, if the `authz` opaque information is present in the URL, this will be part of the redirection request.
|
Here I merged it, as the usual test runs went fine. I just have some concerns over how many people may remember to add "http.header2cgi Authorization authz" to their configuration. At the same time making this the default may be excessive. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If opaque information is given by the user as part of the URL (i.e.,
GET /foo?bar=1), then include this opaque information in the redirection string.Previously, opaque information was dropped and only the resource was used. This is problematic in cases where the opaque information contains important authorization details (think: signed URLs).
Additionally, the TPC handler is updated to perform correctly in this situation.
With this PR, if
http.header2cgi Authorization authzis set in the configuration, the token will be moved from the headers to the opaque information and now included in the redirect. Thus, clients which drop theAuthorization:header upon redirect (this includes the latest versions ofcurl!) will now work by default with an Xrootd cluster.Fixes behavior observed in the WLCG DOMA testing.