avoid the use of Module::Build::Compat in Build.PL #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Module::Build::Compat is a bag of razorblades - and since either straight EUMM or having Dist::Zilla generate both a Makefile.PL and a Build.PL are almost certainly possible if ::Compat usage is possible, I see no reason to encourage users to stick any part of their anatomy into said bag. |
If ExtUtils::MakeMaker can be used to build the distribution identically, it is much preferable for the author to simply use EUMM rather than Module::Build. Users should not be using this mode without careful consideration.
karenetheridge
force-pushed
the
topic/no_mb_compat
branch
from
63a482f
to
2cf1bdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ExtUtils::MakeMaker can be used to build the distribution identically, it
is much preferable for the author to simply use EUMM rather than
Module::Build. Users should not be using this mode without careful
consideration.