Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid the use of Module::Build::Compat in Build.PL #51

Merged
merged 2 commits into from Mar 23, 2017
Merged

avoid the use of Module::Build::Compat in Build.PL #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c6ca10
ignore EUMM artifact
karenetheridge May 22, 2015
2cf1bdf
avoid the use of Module::Build::Compat in Build.PL
karenetheridge May 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -21,3 +21,4 @@ module-starter-*.tar.gz
t/data/MyModule-Test/*
t/data/Book-Park-Mansfield/*
t/data/loop/*
/_eumm/
3 changes: 3 additions & 0 deletions Changes
View file
Open in desktop
@@ -1,5 +1,8 @@
Revision history for Perl extension Module::Starter

* GH#51: drop use of Module::Build::Compat in Build.PL (Karen
Etheridge)

1.71 Fri Jan 30 13:28:31 2015
* GH #47: create_t breaks plugins. (David Pottage)

Expand Down
1 change: 0 additions & 1 deletion lib/Module/Starter/Simple.pm
View file
Open in desktop
Expand Up @@ -920,7 +920,6 @@ my \$builder = Module::Build->new(
#'Foo::Bar::Module' => 5.0401,
},
add_to_cleanup => [ '$self->{distro}-*' ],
create_makefile_pl => 'traditional',
);

\$builder->create_build_script();
Expand Down
7 changes: 1 addition & 6 deletions t/test-dist.t
View file
Open in desktop
Expand Up @@ -593,7 +593,7 @@ sub parse_file_start {
);
}
elsif ($basefn eq 'Build.PL' && $self->{builder} eq 'Module::Build') {
plan tests => 11;
plan tests => 10;
$self->parse($mswb_re,
"Min/Strict/Warning/Builder"
);
Expand Down Expand Up @@ -637,11 +637,6 @@ sub parse_file_start {
qr/\A\s*add_to_cleanup *=> \Q[ '$distro-*' ],\E\n/ms,
"add_to_cleanup",
);

$self->parse(
qr/\A\s*create_makefile_pl *=> \Q'traditional',\E\n/ms,
"create_makefile_pl",
);
}
elsif ($basefn eq 'Makefile.PL' && $self->{builder} eq 'ExtUtils::MakeMaker') {
plan tests => 11;
Expand Down