Purge trailing whitespace in source files #14

Merged
merged 1 commit into from Mar 22, 2017

Conversation

Projects
None yet
2 participants
@paultcochrane
Collaborator

paultcochrane commented Mar 20, 2017

There is trailing whitespace in the corpus data, however that's very likely significant, so it is not removed in this commit. Some trailing spaces were removed from example ipconfig output in the comments, hence this has no impact on the running of the program.

Trailing whitespace is seen in some projects as bad practice (e.g. the Linux kernel) and is hence explicitly forbidden; other projects see its removal as plain nit-picking. This PR is submitted in the hope that it is helpful, however if you don't see any need to remove such whitespace I'm happy if you close the PR as unmerged. I've split up the PR into several commits so that the diffs are smaller; if you wish for the commits to be collected into one large commit (and thus reduce noise in the git history), just let me know and I'll rebase and force push an update to this branch. If you have any questions or comments concerning the PR, please simply contact me!

Purge trailing whitespace in source files
There is trailing whitespace in the corpus data, however that's very
likely significant, so it is not removed in this commit.  Some trailing
spaces were removed from example `ipconfig` output in the comments,
hence this has no impact on the running of the program.

@xsawyerx xsawyerx merged commit f66bdce into xsawyerx:master Mar 22, 2017

@xsawyerx

This comment has been minimized.

Show comment
Hide comment
@xsawyerx

xsawyerx Mar 22, 2017

Owner

Merged, thanks! 👍

Owner

xsawyerx commented Mar 22, 2017

Merged, thanks! 👍

@paultcochrane paultcochrane deleted the paultcochrane:pr/purge-trailing-whitespace branch Apr 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment