Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge trailing whitespace in source files #14

Merged

Conversation

paultcochrane
Copy link
Collaborator

There is trailing whitespace in the corpus data, however that's very likely significant, so it is not removed in this commit. Some trailing spaces were removed from example ipconfig output in the comments, hence this has no impact on the running of the program.

Trailing whitespace is seen in some projects as bad practice (e.g. the Linux kernel) and is hence explicitly forbidden; other projects see its removal as plain nit-picking. This PR is submitted in the hope that it is helpful, however if you don't see any need to remove such whitespace I'm happy if you close the PR as unmerged. I've split up the PR into several commits so that the diffs are smaller; if you wish for the commits to be collected into one large commit (and thus reduce noise in the git history), just let me know and I'll rebase and force push an update to this branch. If you have any questions or comments concerning the PR, please simply contact me!

There is trailing whitespace in the corpus data, however that's very
likely significant, so it is not removed in this commit.  Some trailing
spaces were removed from example `ipconfig` output in the comments,
hence this has no impact on the running of the program.
@xsawyerx xsawyerx merged commit f66bdce into xsawyerx:master Mar 22, 2017
@xsawyerx
Copy link
Owner

Merged, thanks! 👍

@paultcochrane paultcochrane deleted the pr/purge-trailing-whitespace branch April 15, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants