Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0234: Checksums are being sent using session-info, not transport-info messages #154

Closed
piotrjurkiewicz opened this issue Feb 28, 2016 · 1 comment
Closed

XEP-0234: Checksums are being sent using session-info, not transport-info messages #154

piotrjurkiewicz opened this issue Feb 28, 2016 · 1 comment

Comments

@piotrjurkiewicz
Copy link

Now XEP says the following:

Note: Computing the hash of the file before sending it can slow down the process of file transfer, because the sending application needs to process the file twice. The File Sender might prefer to send the hash after the file transfer has begun, using a transport-info message as described under Checksum.

Should be:

Note: Computing the hash of the file before sending it can slow down the process of file transfer, because the sending application needs to process the file twice. The File Sender might prefer to send the hash after the file transfer has begun, using a session-info message as described under Checksum.
@piotrjurkiewicz piotrjurkiewicz changed the title XEP-0234: Cheksums are being sent using session-info, not transport-info messages XEP-0234: Checksums are being sent using session-info, not transport-info messages Feb 28, 2016
legastero added a commit to legastero/xeps that referenced this issue Feb 28, 2016
@legastero
XEP-0234: Specify session-info instead of transport-info
49838af 
Fixes xsf#154
@legastero legastero mentioned this issue Feb 28, 2016
Closed
@legastero
Copy link
Contributor

Thanks! I've submitted a PR to fix the issue.

tfar pushed a commit to tfar/xeps that referenced this issue May 16, 2016
@legastero @tfar
XEP-0234: Specify session-info instead of transport-info
d1c2daf 
Fixes xsf#154

XEP-0234: Remove extraneous initiator attribute from examples

add patch revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@legastero @piotrjurkiewicz