XEP-0428: Change schema int types to xs:unsignedInt #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous type was xs:integer, which allows for arbitrary large integers, and also negative integers. Negative values do not make sense when referencing characters and limiting the size of the integer to 32 bit is, I think, reasonable as that would still allow referencing in 4 GiB of text (and that should probably exceed any stanza size limit).
github-actions
bot
added
the
Needs Author
|
Change is fine, except that schema is not normative and therefore this is an editorial change, thus should be version 0.2.1, not 0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous type was xs:integer, which allows for arbitrary large
integers, and also negative integers. Negative values do not make sense
when referencing characters and limiting the size of the integer to 32
bit is, I think, reasonable as that would still allow referencing in 4
GiB of text (and that should probably exceed any stanza size limit).