Explicit Message Encryption ProtoXEP: Add a 0.0.2 version #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| installing an appropriate plugin, your message will be displayed | ||
| shortly.</p> | ||
| <p>🔒 This message was encrypted with OpenPGP for XMPP | ||
| (urn:xmpp:openpgp:0), downloading and installing an appropriate plugin, |
There was a problem hiding this comment.
I think the wording can be improved. How about something like
This message was encrypted with OpenPGP for XMPP (urn:xmpp:openpgp:0). Download the OpenPGP plugin to enable this encryption method.
There was a problem hiding this comment.
I actually just dropped this message, the first one was enough.
- Made the 'name' attribute optional for existing mechanisms. - Added a remark about the possibility to hide encrypted messages following user input. - Made explicit that this protocol affects any encryption mechanism, present or future, not only those listed here. - Display the namespace of the encryption mechanism in the default messages. - Remove the second example message, which didn’t add any useful information.
Flowdalic
added
the
Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following user input.
present or future, not only those listed here.
messages.