Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0065: Remove duplicate example #471

Merged
merged 1 commit into from Sep 15, 2017
Merged

XEP-0065: Remove duplicate example #471

merged 1 commit into from Sep 15, 2017

Conversation

vanitasvitae
Copy link
Contributor

Example 10 was a duplicate (the stanza was a copy of ex. 9, the description a copy of example 11) so I removed it.

@horazont horazont added Editorial Changes All changes in the PR are purely editorial. Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. labels Aug 24, 2017
horazont
horazont approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@horazont horazont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. This removes normative language, but it is an exact duplicate of the above. The incorrect example (they are slightly different) is removed correctly.

@horazont horazont self-assigned this Aug 24, 2017
@horazont horazont added Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. and removed Editorial Changes All changes in the PR are purely editorial. Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. labels Aug 24, 2017
@horazont
Copy link
Contributor

Kevin suggested to play it safe and let this pass through council.

@horazont horazont added this to To-be-submitted in Council Tracking Aug 25, 2017
@horazont horazont moved this from To-be-submitted to On agenda in Council Tracking Aug 29, 2017
@horazont horazont moved this from On agenda to Voting in progress in Council Tracking Aug 31, 2017
@horazont
Copy link
Contributor

horazont commented Sep 1, 2017 •
edited

Voting started on 2017-08-30, voting period ends on 2017-09-13.

@horazont horazont moved this from Voting in progress to Done in Council Tracking Sep 11, 2017
@horazont horazont added Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time. and removed Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. labels Sep 11, 2017
@horazont horazont removed this from Done in Council Tracking Sep 11, 2017
@horazont horazont merged commit 24f0bd8 into xsf:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horazont horazont horazont approved these changes

Assignees

@horazont horazont

Labels
Ready To Merge No acknowledgements of other parties are needed anymore. There may be changes to do at merge time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanitasvitae @horazont