Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XEP-0280: Rewrite of the 'Messages Eligible for Carbons Delivery' section #778

Merged
merged 9 commits into from May 15, 2019
Merged

XEP-0280: Rewrite of the 'Messages Eligible for Carbons Delivery' section #778

merged 9 commits into from May 15, 2019

Conversation

ge0rg
Copy link
Contributor

@ge0rg ge0rg commented Apr 5, 2019

This is a re-work of #434, which got closed for purely formal reasons.

This time without Hints and without version-bumping the weasel words:

  • a95dab9 Improvement of the "Messages Eligible for Carbons Delivery" section that conveys the same set of rules in less words
  • 4b51c8b addition of clear MUC / MUC-PM instructions, as suggested on standards@
  • 820d7f1 minor wording correction to accomodiate the above changes
  • c7ce949 controversial change of the "Messages Eligible for Carbons Delivery" languge from "serves MAY do this" to "servers SHOULD do this" (based on field experience with running Carbons in the wild). The language in the old XEP is very vague and non-binding, and this patch attempts to make clearly defined rules for clear use cases, so that clients can expect consistent behavior (even though they may not rely on it).
  • 360aea7 improved wording for MUC-PMs from a non-joined MUC, thx to Kev
  • df80944 inclusion of 0184 ACKs and 0085 CSNs as eligible as motivated on standards@.

This is not fully IM-NG compliant, as it is missing the "all messages sent to the bare JID" aspect.

BTW, I volunteer to take over 0280 authorship if the need arises.

@horazont
Copy link
Contributor

horazont commented Apr 6, 2019

@linuxwolf please (I don’t know a github name of the other author)

@horazont horazont self-assigned this Apr 6, 2019
@horazont horazont added Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. and removed Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. labels Apr 6, 2019
horazont added a commit that referenced this pull request Apr 6, 2019
@horazont
XEP-0280: Move from Experimental status
f2bdb17 
The LC has long ended and no decision either way has come. Stuff
is going on though [1], so not moving to Deferred yet.

   [1]: #778
@ge0rg
Copy link
Contributor Author

ge0rg commented Apr 24, 2019

I've rebased the commits onto current master and incorporated council feedback from 2019-04-17:

  • bd18afe documents how the features can be treated as REQUIRED if urn:xmpp:carbons:rules:0 is advertised
  • a53d188 documents all the changes from prior versions, as asked for by server implementors.

@horazont horazont added Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change. and removed Needs Author The XEP is experimental and the PR was not made by the author. The author needs to acknowledge it. labels May 8, 2019
@horazont horazont merged commit e6cb129 into xsf:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@horazont horazont

Labels
Needs Council The affected XEP has the Council as Approving Body and it needs to decide on the change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ge0rg @horazont