close #7; fix a memory leak

xslate · Sep 29, 2013 · f378af9 · f378af9
1 parent 4ec2387
commit f378af9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/t/900_mouse_bugs/015_issue7_memleak.t b/t/900_mouse_bugs/015_issue7_memleak.t
@@ -0,0 +1,20 @@
+use strict;
+use Test::Requires qw(Test::LeakTrace);
+use Test::More tests => 1;
+
+{
+    package Foo;
+
+    use Mouse;
+
+    has 'bar' => (
+        is => 'rw',
+        trigger => sub { }
+    );
+}
+
+no_leaks_ok {
+    my $foo = Foo->new(bar => 'TEST');
+    $foo->bar('bar');
+};
+
diff --git a/xs-src/MouseAccessor.xs b/xs-src/MouseAccessor.xs
@@ -216,7 +216,7 @@ mouse_attr_set(pTHX_ SV* const self, MAGIC* const mg, SV* value){
        passed to the trigger */
     if(flags & MOUSEf_ATTR_HAS_TRIGGER && has_slot(self, slot)){
         has_old_value = 1;
-        old_value = newSVsv( get_slot(self, slot) );
+        old_value = sv_mortalcopy( get_slot(self, slot) );
     }
 
     if(flags & MOUSEf_ATTR_HAS_TC){