Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noisy on bleadperl #38

Closed
andk opened this issue Dec 19, 2014 · 5 comments
Closed

Noisy on bleadperl #38

andk opened this issue Dec 19, 2014 · 5 comments

Comments

@andk
Copy link

andk commented Dec 19, 2014

As per subject. Sample PASS report with the warnings:

http://www.cpantesters.org/cpan/report/48501326

Related bleadperl ticket: https://rt.perl.org/rt3/Ticket/Display.html?id=123213

HTH&&Thanks,
(Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)

@eserte
Copy link

eserte commented Dec 22, 2014

The "Constants from lexical variables potentially modified elsewhere are deprecated" warning may also affect other modules with nowarnings-like tests (seen with TOBYINK/Role-Inspector-0.005.tar.gz, for example).

@gfx gfx closed this as completed in c00b048 Dec 23, 2014
@gfx
Copy link
Member

gfx commented Dec 23, 2014

Fixed in c00b048, which looks strange, though. In fact, I believe this is a bug in Perl.

@eserte
Copy link

eserte commented Dec 24, 2014

I would say Perl is just too dumb to recognize that $xs is not changed after using in the constant generation.

@gfx
Copy link
Member

gfx commented Dec 24, 2014

I should have used constant.pm to define constant subroutines :(

@eserte
Copy link

eserte commented Apr 3, 2015

Can we have a CPAN release with this fix? There is a number of CPAN modules which have fail reports because of this warning in Mouse, e.g. https://rt.cpan.org/Ticket/Display.html?id=101085

gfx added a commit that referenced this issue Apr 12, 2015
Changelog diff is:

diff --git a/Changes b/Changes
index f1e2ea3..3459479 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
 Revision history for Mouse

 {{$NEXT}}
+
+2.4.2 2015-04-12T01:22:02Z
     - Fixed #40; 'use strict' not enabled when 'use 5.010' follows 'use Mouse'
     - Fixed #39; New warnings in Perl 5.21.x: redundant arguments for sprintf
     - Fixed #38; Avoid warnings introduced in Perl 5.21.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants