Merge pull request #85 from xsnippet/no-empty-snippets

Do not allow empty snippets
xsnippet · Apr 26, 2018 · a6cd909 · a6cd909
2 parents 7f672c1 + 7ed2d5e
commit a6cd909
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/tests/resources/test_snippets.py b/tests/resources/test_snippets.py
@@ -565,6 +565,10 @@ async def test_post_snippet(testapp, testconf, snippet, rv):
         {'content': 42},
         {'message': '`content` - must be of string type.'},
     ),
+    (
+        {'content': ''},
+        {'message': '`content` - empty values not allowed.'},
+    ),
     (
         {'content': 'test', 'tags': ['white space']},
         {'message': '`tags` - {0: ["value does not match regex \'[\\\\w_-]+\'"]}.'},
@@ -713,6 +717,10 @@ async def test_put_snippet_not_found(testapp):
         {'content': 42},
         {'message': '`content` - must be of string type.'},
     ),
+    (
+        {'content': ''},
+        {'message': '`content` - empty values not allowed.'},
+    ),
     (
         {'content': 'test', 'tags': ['white space']},
         {'message': '`tags` - {0: ["value does not match regex \'[\\\\w_-]+\'"]}.'},
@@ -783,6 +791,10 @@ async def test_patch_snippet_not_found(testapp):
         {'content': 42},
         {'message': '`content` - must be of string type.'},
     ),
+    (
+        {'content': ''},
+        {'message': '`content` - empty values not allowed.'},
+    ),
     (
         {'tags': ['white space']},
         {'message': '`tags` - {0: ["value does not match regex \'[\\\\w_-]+\'"]}.'},

diff --git a/xsnippet/api/resources/snippets.py b/xsnippet/api/resources/snippets.py
@@ -36,7 +36,7 @@ async def _write(resource, service_fn, *, status, conf):
     v = cerberus.Validator({
         'id': {'type': 'integer', 'readonly': True},
         'title': {'type': 'string'},
-        'content': {'type': 'string', 'required': True},
+        'content': {'type': 'string', 'required': True, 'empty': False},
         'syntax': {'type': 'string'},
         'tags': {'type': 'list',
                  'schema': {'type': 'string', 'regex': '[\w_-]+'}},