Skip to content

Commit

Permalink
Cdl query issues (demisto#28021)
Browse files Browse the repository at this point in the history
* Made sure limit won't be an empty string

* Made sure limit won't be an empty string

* Releas notes

* Releas notes

* Docker image

* Update Packs/CortexDataLake/ReleaseNotes/1_4_7.md

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>

* Update Packs/CortexDataLake/Integrations/CortexDataLake/CortexDataLake.py

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>

---------

Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
  • Loading branch information
2 people authored and xsoar-bot committed Aug 2, 2023
1 parent ed0cead commit 40a2b0a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ def build_query(args, table_name):
query_start_time, query_end_time = query_timestamp(args)
timestamp_limitation = f'time_generated BETWEEN TIMESTAMP("{query_start_time}") AND ' \
f'TIMESTAMP("{query_end_time}") '
limit = args.get('limit', '5')
limit = args.get('limit') or '5'
where += f' AND {timestamp_limitation}' if where else timestamp_limitation
query = f'SELECT {fields} FROM `firewall.{table_name}` WHERE {where} LIMIT {limit}' # noqa: S608
return fields, query
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1975,7 +1975,7 @@ script:
type: String
- description: Use this command in case your authentication calls fail due to internal call-limit, the command will reset the limit cache.
name: cdl-reset-authentication-timeout
dockerimage: demisto/python_pancloud_v2:1.0.0.62401
dockerimage: demisto/python_pancloud_v2:1.0.0.64955
isfetch: true
runonce: false
script: '-'
Expand Down
7 changes: 7 additions & 0 deletions Packs/CortexDataLake/ReleaseNotes/1_4_7.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@

#### Integrations

##### Cortex Data Lake XSOAR Connector

- Fixed an issue where providing an empty *limit* value returned an error for **cdl-query-file-data** and **cdl-query-url-logs**.
- - Updated the Docker image to: *demisto/python_pancloud_v2:1.0.0.64955*.
4 changes: 2 additions & 2 deletions Packs/CortexDataLake/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Cortex Data Lake by Palo Alto Networks",
"description": "Palo Alto Networks Cortex Data Lake XSOAR Connector provides cloud-based, centralized log storage and aggregation for your on-premise, virtual (private cloud and public cloud) firewalls, for Prisma Access, and for cloud-delivered services such as Cortex XDR",
"support": "xsoar",
"currentVersion": "1.4.6",
"currentVersion": "1.4.7",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand All @@ -25,4 +25,4 @@
"marketplaces": [
"xsoar"
]
}
}

0 comments on commit 40a2b0a

Please sign in to comment.