Skip to content

Commit

Permalink
Align Credentials Part 2 (demisto#27350)
Browse files Browse the repository at this point in the history
* Attlasian_IAM complete

* C2sec complete

* Tidy complete

* CircleCI complete

* update release notes

* Update .pack-ignore

* update docker

* updated know words

* updated release notes

* removed CJ105 from .pack-ignore
  • Loading branch information
jlevypaloalto authored and xsoar-bot committed Jul 26, 2023
1 parent 207ad7d commit 84c57b5
Show file tree
Hide file tree
Showing 21 changed files with 101 additions and 36 deletions.
2 changes: 1 addition & 1 deletion Packs/Attlasian/.pack-ignore
@@ -1,5 +1,5 @@
[file:Attlasian_IAM.yml]
ignore=BA108,BA109,IN145
ignore=BA108,BA109

[file:README.md]
ignore=RM106
Expand Down
Expand Up @@ -178,7 +178,7 @@ def main():
base_url = params.get('url')
if base_url[-1] != '/':
base_url += '/'
access_token = params.get('access_token')
access_token = params.get('access_token_creds', {}).get('password') or params.get('access_token')
directory_id = params.get('directory_id')

mapper_in = params.get('mapper_in')
Expand Down
15 changes: 11 additions & 4 deletions Packs/Attlasian/Integrations/Attlasian_IAM/Attlasian_IAM.yml
Expand Up @@ -9,8 +9,14 @@ configuration:
type: 0
- display: Access Token
name: access_token
required: true
required: false
type: 4
hidden: true
- name: access_token_creds
required: false
type: 9
displaypassword: Access Token
hiddenusername: true
- display: Directory ID
name: directory_id
required: true
Expand All @@ -23,12 +29,12 @@ configuration:
name: proxy
required: false
type: 8
- additionalinfo: If set to false, iam-create-user command will be skipped, and user will not be created.
defaultvalue: 'true'
- defaultvalue: 'true'
display: Allow creating users
name: create_user_enabled
required: false
type: 8
additionalinfo: If set to false, iam-create-user command will be skipped, and user will not be created.
- defaultvalue: 'true'
display: Allow updating users
name: update_user_enabled
Expand Down Expand Up @@ -59,6 +65,7 @@ configuration:
name: mapper_out
required: true
type: 0

description: Integrate with Atlassian's services to execute CRUD operations for employee lifecycle processes.
display: Atlassian IAM
name: Atlassian IAM
Expand Down Expand Up @@ -258,7 +265,7 @@ script:
description: Retrieves a User Profile schema, which holds all of the user fields within the application. Used for outgoing-mapping through the Get Schema option.
execution: false
name: get-mapping-fields
dockerimage: demisto/python3:3.10.11.54132
dockerimage: demisto/python3:3.10.12.62631
feed: false
isfetch: false
longRunning: false
Expand Down
7 changes: 7 additions & 0 deletions Packs/Attlasian/ReleaseNotes/1_1_13.md
@@ -0,0 +1,7 @@

#### Integrations

##### Atlassian IAM

- You can now use credentials when configuring the *Access Token* field.
- Updated the Docker image to demisto/python3:3.10.12.62631.
2 changes: 1 addition & 1 deletion Packs/Attlasian/pack_metadata.json
Expand Up @@ -2,7 +2,7 @@
"name": "Atlassian IAM",
"description": "Atlassian IAM Integration allows the customers to do the generic ILM management operations such as create, update, delete, etc.",
"support": "xsoar",
"currentVersion": "1.1.12",
"currentVersion": "1.1.13",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
4 changes: 3 additions & 1 deletion Packs/C2sec/.pack-ignore
Expand Up @@ -2,8 +2,10 @@
ignore=RM104

[file:C2sec.yml]
ignore=IN145,BA124
ignore=BA124

[file:C2sec_image.png]
ignore=IM111

[known_words]
irisk
2 changes: 1 addition & 1 deletion Packs/C2sec/Integrations/C2sec/C2sec.py
Expand Up @@ -10,7 +10,7 @@
# disable insecure warnings
urllib3.disable_warnings()

API_KEY = demisto.params()['apikey']
API_KEY = demisto.params().get('apikey_creds', {}).get('password') or demisto.params().get('apikey')
HEADERS = {
'Content-Type': 'application/json',
'Accept': 'application/json'
Expand Down
17 changes: 13 additions & 4 deletions Packs/C2sec/Integrations/C2sec/C2sec.yml
Expand Up @@ -16,20 +16,27 @@ configuration:
name: apikey
defaultvalue: ""
type: 4
required: true
required: false
hidden: true
- name: apikey_creds
type: 9
required: false
displaypassword: API Key
hiddenusername: true
- display: Default domain name
name: domainName
defaultvalue: ""
type: 0
required: true
defaultvalue: ''
- display: Trust any certificate (not secure)
name: unsecure
type: 8
required: false
type: 8
- display: Use system proxy settings
name: proxy
required: false
type: 8

script:
script: '-'
type: python
Expand Down Expand Up @@ -192,4 +199,6 @@ script:
type: string
description: Query Data for specific component for companies in the portfolio
runonce: false
dockerimage: demisto/python3:3.10.11.54132
dockerimage: demisto/python3:3.10.12.62631
tests:
- No tests (auto formatted)
7 changes: 7 additions & 0 deletions Packs/C2sec/ReleaseNotes/1_0_9.md
@@ -0,0 +1,7 @@

#### Integrations

##### C2sec irisk

- You can now use credentials when configuring the *API Key* field.
- Updated the Docker image to demisto/python3:3.10.12.62631.
2 changes: 1 addition & 1 deletion Packs/C2sec/pack_metadata.json
Expand Up @@ -2,7 +2,7 @@
"name": "C2sec irisk",
"description": "Understand Your Cyber Exposure as Easy as a Google Search",
"support": "xsoar",
"currentVersion": "1.0.8",
"currentVersion": "1.0.9",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
2 changes: 0 additions & 2 deletions Packs/CircleCI/.pack-ignore
@@ -1,2 +0,0 @@
[file:CircleCI.yml]
ignore=IN145
2 changes: 1 addition & 1 deletion Packs/CircleCI/Integrations/CircleCI/CircleCI.py
Expand Up @@ -298,7 +298,7 @@ def main() -> None:
verify_certificate: bool = not params.get('insecure', False)
proxy: bool = params.get('proxy', False)

api_key: str = params.get('api_key', '')
api_key: str = params.get('api_key_creds', {}).get('password') or params.get('api_key', '')
vc_type: str = params.get('vcs_type', '')
organization: str = params.get('organization', '')
project: str = params.get('project', '')
Expand Down
21 changes: 14 additions & 7 deletions Packs/CircleCI/Integrations/CircleCI/CircleCI.yml
Expand Up @@ -13,23 +13,29 @@ configuration:
name: api_key
required: false
type: 4
hidden: true
- name: api_key_creds
type: 9
required: false
displaypassword: The API key
hiddenusername: true
- display: Version control system type
name: vcs_type
type: 15
required: true
additionalinfo: Type of version control system
options:
- github
- bitbucket
additionalinfo: Type of version control system
- display: Organization name
name: organization
type: 0
required: true
additionalinfo: Name of the organization
- display: Project Name
name: project
type: 0
required: true
type: 0
additionalinfo: Name of the project
- display: Trust any certificate (not secure)
name: insecure
Expand All @@ -39,6 +45,7 @@ configuration:
name: proxy
required: false
type: 8

description: Gets the details of the CircleCI workflows; including the details of the last runs and the jobs, and retrieves the artifacts of the jobs.
display: CircleCI
name: CircleCI
Expand Down Expand Up @@ -164,8 +171,8 @@ script:
default: true
auto: PREDEFINED
predefined:
- github
- bitbucket
- github
- bitbucket
defaultValue: github
- default: false
description: The organization from which to retrieve artifacts. Defaults to the organization instance parameter.
Expand Down Expand Up @@ -259,8 +266,8 @@ script:
default: true
auto: PREDEFINED
predefined:
- github
- bitbucket
- github
- bitbucket
defaultValue: github
- default: false
description: Organization from which to retrieve workflow last runs. Defaults to the organization instance parameter.
Expand Down Expand Up @@ -335,7 +342,7 @@ script:
script: '-'
type: python
subtype: python3
dockerimage: demisto/python3:3.10.11.54132
dockerimage: demisto/python3:3.10.12.62631
fromversion: 5.5.0
tests:
- No tests (auto formatted)
7 changes: 7 additions & 0 deletions Packs/CircleCI/ReleaseNotes/1_0_23.md
@@ -0,0 +1,7 @@

#### Integrations

##### CircleCI

- You can now use credentials when configuring the *API Key* field.
- Updated the Docker image to demisto/python3:3.10.12.62631.
2 changes: 1 addition & 1 deletion Packs/CircleCI/pack_metadata.json
Expand Up @@ -2,7 +2,7 @@
"name": "CircleCI",
"description": "CircleCI is a modern continuous integration and continuous delivery (CI/CD) platform. CircleCI automates the building, testing, and deployment of software.",
"support": "xsoar",
"currentVersion": "1.0.22",
"currentVersion": "1.0.23",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
5 changes: 2 additions & 3 deletions Packs/Tidy/.pack-ignore
@@ -1,9 +1,8 @@
[file:Tidy.yml]
ignore=DO102,DO104,DO107,IN145,BA124,CJ105,RM110
ignore=DO102,DO104,DO107,BA124,RM110

[file:README.md]
ignore=RM104

[file:Tidy_image.png]
ignore=IM111

ignore=IM111
5 changes: 5 additions & 0 deletions Packs/Tidy/Integrations/Tidy/README.md
@@ -1,18 +1,23 @@
## Tidy

### Description:

Usually, the main bottlenecks in an on-boarding process are the various software and programs required for the new recruit's computer.
Whether if it's a developer, customer success engineer, or a product specialist, on average it takes about three days to get everything up and running. Also, this process generally requires help from other colleagues.
The **Tidy** pack reduces the on-boarding process for new recruits to a matter of minutes.
The **Tidy** pack uses **Ansible** to connect to the new recruit's laptop over ssh and executing predefined commands.

### Main use cases

With the **Tidy** pack you can create a role-based playbook that will execute all required installations for the new recruit.

- Install languages with specific versions (currently Python, Node and Go are supported).
- Create a GitHub SSH key and clone all relevant git repositories.
- Install all relevant programs using **homebrew**.
- Install **zsh** and configure bash_profile / bash_rc.

#### Supported actions

- Install **pyenv** with specific Python versions.
- Install **goenv** with specific Go versions.
- Install **nodenv** with specific Node versions.
Expand Down
8 changes: 4 additions & 4 deletions Packs/Tidy/Integrations/Tidy/Tidy.py
Expand Up @@ -8,7 +8,6 @@
"""


from socket import error
from typing import Any, Callable, Dict, List

from ansible_runner import Runner, run
Expand Down Expand Up @@ -55,7 +54,7 @@ def test(self) -> None:
ssh.close()
except AuthenticationException as e:
raise DemistoException(f"Authentication details isn't valid.\nFull error: {e}")
except error as e:
except OSError as e:
raise DemistoException(f"SSH socket isn't enabled in endpoint.\nFull error: {e}")
except SSHException as e:
raise DemistoException(f"Hostname \"{self.hostname}\" isn't valid!.\nFull error: {e}")
Expand Down Expand Up @@ -657,8 +656,9 @@ def main() -> None:

# Tidy client configuration
hostname = demisto.getArg("hostname") or demisto.getParam("hostname")
user = demisto.getArg("user") or demisto.getParam("user")
password = demisto.getArg("password") or demisto.getParam("password")
user = demisto.getArg("user") or demisto.params().get('user_creds', {}).get('identifier') or demisto.params().get("user")
password = demisto.getArg("password") or demisto.params().get(
'user_creds', {}).get('password') or demisto.params().get("password")
ssh_key = demisto.getParam("ssh_key")
client = TidyClient(
hostname=hostname,
Expand Down
14 changes: 11 additions & 3 deletions Packs/Tidy/Integrations/Tidy/Tidy.yml
Expand Up @@ -11,18 +11,26 @@ configuration:
- additionalinfo: Endpoint user to be installed. (Can overide in command)
display: User
name: user
required: true
required: false
type: 0
hidden: true
- additionalinfo: User login password. (Can overide in command)
display: Password
name: password
required: true
required: false
type: 4
hidden: true
- display: User
name: user_creds
required: false
type: 9
displaypassword: Password
- additionalinfo: The ssh key is used to login to an AWS mac machine - for testing purposes.
display: SSH Key
name: ssh_key
required: false
type: 14

description: Tidy integration handle endpoints enviorment installation.
display: Tidy
name: Tidy
Expand Down Expand Up @@ -594,7 +602,7 @@ script:
- arguments: []
description: Install python environment.
name: tidy-python-env
dockerimage: demisto/tidy:1.0.0.31762
dockerimage: demisto/tidy:1.0.0.62989
runonce: false
script: ''
subtype: python3
Expand Down
9 changes: 9 additions & 0 deletions Packs/Tidy/ReleaseNotes/1_0_10.md
@@ -0,0 +1,9 @@

#### Integrations

##### Tidy

- You can now use credentials when configuring the following fields:
- *User*
- *Password*
- Updated the Docker image to demisto/tidy:1.0.0.62989.
2 changes: 1 addition & 1 deletion Packs/Tidy/pack_metadata.json
Expand Up @@ -2,7 +2,7 @@
"name": "Tidy",
"description": "Tidy integration handle endpoints environment installation.",
"support": "xsoar",
"currentVersion": "1.0.9",
"currentVersion": "1.0.10",
"author": "Cortex XSOAR",
"url": "",
"email": "https://www.paloaltonetworks.com/cortex",
Expand Down

0 comments on commit 84c57b5

Please sign in to comment.