This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Master #157
Merged
Master #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dojo collapse doesn't work with latest dojo version, in dojo bootstrap, support.js uses dojo lang.isArray to check if data is array, which returns false even when data is an array since Dojo lang has changed the way to check an array, it causes collapse not working. The solution is to use JavaScript data instanceof Array instead of dojo lang.isArray
Fix collapse issue with latest dojo version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dojo collapse doesn't work with latest dojo version, in dojo bootstrap, support.js uses dojo lang.isArray to check if data is array, which returns false even when data is an array since Dojo lang has changed the way to check an array, it causes collapse not working. The solution is to use JavaScript data instanceof Array instead of dojo lang.isArray