-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update:add validation functions to validate user input at init.ts script #18
Conversation
update:move init.ts script contents into src/
…ue implicitly, Showing a message to say so
@xstevenyung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I like this approach a lot, just some minor changes and we should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops wrong button
@xstevenyung |
thanks a lot @sinyo-matu , amazing work ! 👍 |
Background
In init.ts,
I think user input may need some validation to reduce unexpected or confusing behavior.
Move init.ts script contents into src/ may make our code cleaner
What Changed
isValidaUrl
andisValidDir