Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Io buffer and loss rename #484

Closed
wants to merge 17 commits into from

Conversation

freddieknets
Copy link
Contributor

Description

Three quick but important changes:

  • If no io_buffer is specified at the tracker initialisation, but (some of) the line elements have a io_buffer specidied, this one is automatically assigned to the tracker (it is checked that they all point to the same io_buffer)
  • Renamed allow_backtrack into allow_loss_refinement
  • Drift slices were missing allow_loss_refinement=True

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@giadarol
Copy link
Member

already merged

@giadarol giadarol closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants