Support for globbing in script names #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
xt0rted
commented
Aug 12, 2022
| @@ -77,32 +79,29 @@ public async Task<int> InvokeAsync(InvocationContext context) | |||
| return 0; | |||
| } | |||
|
|
|||
| // The `env` script is special so if it's not explicitly declared we act like it was | |||
| var scriptsToRun = scripts | |||
| .Select(script => (name: script, exists: project.Scripts!.ContainsKey(script) || script == "env")) | |||
There was a problem hiding this comment.
Turns out this (script == "env") is a bug and was fixed below in the new version. Long term the case insensitive support should probably be removed to both simplify things and reduce the number of edge case bugs like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you run multiple scripts in series using wildcards. This means
test:*will matchtest:unitandtest:integrationand run them in series in the order they're listed in theglobal.jsonfile.Globbing is handled by the DotNet.Glob library and supports all of its patterns and wildcards. This may need to change based on user feedback and performance.
Working on this made me realize there's a lot of code to make script names case insensitive while
npmis case sensitive. To simplify things and reduce the possibility of bugs we should probably do the same.