Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for collaborator roles #563

Open
xt0rted opened this issue Aug 17, 2022 · 1 comment · May be fixed by #669
Open

Support for collaborator roles #563

xt0rted opened this issue Aug 17, 2022 · 1 comment · May be fixed by #669
Labels
enhancement New feature or request

Comments

@xt0rted
Copy link
Owner

xt0rted commented Aug 17, 2022 •
edited
Loading

The Triage and Maintain roles need to be added. It looks like these aren't returned from the rest api, so this call will need to be switched to graphql.
@xt0rted xt0rted added the enhancement New feature or request label Aug 17, 2022
@NiccoloFei NiccoloFei linked a pull request Jun 5, 2023 that will close this issue
Open
@NiccoloFei
Copy link

NiccoloFei commented Jun 5, 2023 •
edited
Loading

Hi @xt0rted

It seems like there has been some Github API changes recently, and the REST API has now started returning these 2 roles as well. That currently makes the action fail in case a user is assigned to any of those 2 roles (even if the permission required by the action is lower than the user's one). I've opened #669 to add these new collaborator roles, do you mind taking a look at it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for collaborator roles NiccoloFei/slash-command-action
2 participants
@xt0rted @NiccoloFei