Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make batchConn more generic #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make batchConn more generic #200

wants to merge 2 commits into from

Conversation

zjx20
Copy link

@zjx20 zjx20 commented Apr 25, 2021

Sometimes we would like to implement a custom net.PacketConn, for example the tcpraw. This patch allows kcp-go to leverage the batching ability provided by the custom conn, if possible.

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #200 (b930b19) into master (7450e91) will increase coverage by 0.82%.
The diff coverage is 86.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   82.47%   83.29%   +0.82%     
==========================================
  Files          12       11       -1     
  Lines        1889     1910      +21     
==========================================
+ Hits         1558     1591      +33     
+ Misses        260      250      -10     
+ Partials       71       69       -2     
Impacted Files Coverage Δ
batchconn_linux.go 72.22% <72.22%> (ø)
readloop.go 89.28% <92.10%> (+5.95%) ⬆️
sess.go 84.06% <100.00%> (+0.59%) ⬆️
tx.go 100.00% <100.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7450e91...b930b19. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant