Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 13.0.0 #1019

Closed
wants to merge 2 commits into from
Closed

Release 13.0.0 #1019

wants to merge 2 commits into from

Conversation

serge-sans-paille
Copy link
Contributor

No description provided.

@serge-sans-paille serge-sans-paille mentioned this pull request Apr 29, 2024
Closed
@serge-sans-paille
Copy link
Contributor Author

@pitrou , @cyb70289 and others, can you check this version works fine with your code base? I'll do the same with pythran.

@cyb70289
Copy link
Contributor

cyb70289 commented Apr 30, 2024 •
edited

Did a quick test with apache arrow on arm server. No error found.
-DARROW_COMPUTE=ON -DARROW_PARQUET=ON -DARROW_BUILD_TESTS=ON

apply patch

diff --git a/cpp/thirdparty/versions.txt b/cpp/thirdparty/versions.txt
index 4983f3c..1fbcd8d 100644
--- a/cpp/thirdparty/versions.txt
+++ b/cpp/thirdparty/versions.txt
@@ -113,8 +113,8 @@ ARROW_UCX_BUILD_VERSION=1.12.1
 ARROW_UCX_BUILD_SHA256_CHECKSUM=9bef31aed0e28bf1973d28d74d9ac4f8926c43ca3b7010bd22a084e164e31b71
 ARROW_UTF8PROC_BUILD_VERSION=v2.7.0
 ARROW_UTF8PROC_BUILD_SHA256_CHECKSUM=4bb121e297293c0fd55f08f83afab6d35d48f0af4ecc07523ad8ec99aa2b12a1
-ARROW_XSIMD_BUILD_VERSION=9.0.1
-ARROW_XSIMD_BUILD_SHA256_CHECKSUM=b1bb5f92167fd3a4f25749db0be7e61ed37e0a5d943490f3accdcd2cd2918cc0
+ARROW_XSIMD_BUILD_VERSION=023a505c9bc2bed2f2cb0d5939a97e7825b1e607
+ARROW_XSIMD_BUILD_SHA256_CHECKSUM=b95d3c7acc1c6c0d92e539714ce44c8c08ccfa6beb77a0beaadcc322f0828a12
 ARROW_ZLIB_BUILD_VERSION=1.3.1
 ARROW_ZLIB_BUILD_SHA256_CHECKSUM=9a93b2b7dfdac77ceba5a558a580e74667dd6fede4585b91eefb60f03b72df23
 ARROW_ZSTD_BUILD_VERSION=1.5.6

@serge-sans-paille
Fix scalar version of signbit
29e07fb 
It returns invalid value for nan.

std::signbit appears to be missing on some Windows target for integral
types.
@serge-sans-paille
Release 13.0.0
cf51236
@serge-sans-paille
Copy link
Contributor Author

Everything looks good on pythran bots too: serge-sans-paille/pythran#2188

@JohanMabille
Copy link
Member

JohanMabille commented May 2, 2024 •
edited

Nitpicking: releases should be a commit directly on master / main instead of pull requests. I can cherry-pick the commit and push it directly.

@JohanMabille
Copy link
Member

The signbit fix has been pushed in #1020 and the release commit has been pushed directly to master, let's close this.

@JohanMabille JohanMabille deleted the release/13.0.0 branch May 2, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille Awaiting requested review from JohanMabille

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serge-sans-paille @cyb70289 @JohanMabille