Enabling array-bounds warning #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
force-pushed
the
svector_insert
branch
2 times, most recently
from
e8fbf93
to
c54241d
Compare
|
@DavisVaughan gcc10 is not available on PPA so I cannot test if this fixes the warning, although I'm pretty sure that it should. Do you have the opportunity to test it easily, or is that possible only with a new release when you submit a package to CRAN? |
|
Unfortunately I can't figure out how to test this easily :/ but thanks for looking into it and making an attempt to fix! |
|
Could we please get a new xtensor R package release? |
|
We're going to fix a couple of issues, and then release the stack. The new release should be available next week. |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1909