Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argsort: catching zeros stride leading axis (bugfix) #2238

Merged
merged 1 commit into from
May 17, 2021
Merged

argsort: catching zeros stride leading axis (bugfix) #2238

merged 1 commit into from
May 17, 2021

Conversation

tdegeus
Copy link
Member

@tdegeus tdegeus commented Nov 29, 2020 •
edited
Loading

Fixes a bug where

xt::xtensor<double, 2> A = {{1.4, 1.3, 1.2, 1.1}};
std::cout << xt::argsort(A) << std::endl;

result in unallocated output

This was referenced Nov 29, 2020
Open
Closed
@tdegeus tdegeus changed the title Adding test xsort argsort: catching zeros stride leading axis (bugfix) May 10, 2021
@tdegeus tdegeus force-pushed the argsort branch 2 times, most recently from a677157 to 8089b46 Compare May 11, 2021 16:02
@tdegeus
Copy link
Member Author

tdegeus commented May 11, 2021 •
edited
Loading

I'm not really getting the CI failure: I still return the default return-type for the original implementation of flatten_argsort_impl. Do you get it @JohanMabille ?

@JohanMabille JohanMabille merged commit a8f1a6a into xtensor-stack:master May 17, 2021
@tdegeus tdegeus deleted the argsort branch May 18, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfv wolfv Awaiting requested review from wolfv

@JohanMabille JohanMabille Awaiting requested review from JohanMabille

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdegeus @JohanMabille