Fix and refactor partition #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
fix-partition
branch
from
0da08da
to
6bfafac
Compare
|
Cmake error in CI seems unrelated. |
JohanMabille
requested changes
Feb 24, 2023
| @@ -497,60 +557,20 @@ namespace xt | |||
| } | |||
|
|
|||
| template <class E, class C, class = std::enable_if_t<!xtl::is_integral<C>::value, int>> | |||
| inline auto partition(const xexpression<E>& e, const C& kth_container, std::ptrdiff_t axis = -1) | |||
| inline auto partition(const xexpression<E>& e, C kth_container, std::ptrdiff_t axis = -1) | |||
There was a problem hiding this comment.
This signature is not consistent with the previous overload, where C is passed by const ref. Passing it by value (to avoid the hidden copy) in the previous overload should be the way to go.
Note: the same should be applied to argpartition
There was a problem hiding this comment.
@JohanMabille Actually a copy of the kth container needs to be made in order to sort it so perhaps better to go with a universal reference.
There was a problem hiding this comment.
My point is, if you need a copy of kth_container in the implementation of partition, let's pass this argument by value so that the copy is not hidden to the user.
Co-authored-by:JohanMabille
AntoinePrv
force-pushed
the
fix-partition
branch
from
6bfafac
to
2982403
Compare
JohanMabille
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fix #2651 and refactor (some) of
xsort.hpp.There was a lot of duplications between different functions in this file.
This is far from what I would like to do, but still a good improvement for now!