Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allocators for STL containers owned by xarray and xtensor #81

Merged
merged 4 commits into from
Jan 24, 2017

Conversation

llllllllll
Copy link
Contributor

Adds the ability to specify an allocator type for the elements and shape of an xarray and the ability to specify and allocator for the elements of an xtensor

@SylvainCorlay
Copy link
Member

Thanks @llllllllll this is definitely something we want to allow, also for the SIMD acceleration that we will be enabling soon, which requires the aligned memory allocator implemented in https://github.com/QuantStack/xsimd for better performance.

The failing windows test seems to be legitimate.

@llllllllll
Copy link
Contributor Author

I will look into the windows case sometime this week. Is there a good way to get access to the microsoft compiler on a gnu+linux system to test against?

@JohanMabille
Copy link
Member

@llllllllll I don't know about that, I have both systems installed. I'll have a look on this.

@JohanMabille
Copy link
Member

@llllllllll Adding the namespace xt before fma to disambiguate the call fixes the problem. I think we can use that workaround for now, and dig deeper into this issue later; I'll let you fix it, opening a PR on your PR for such a change is a bit of overkill :)

@llllllllll
Copy link
Contributor Author

Thank you for looking into this!

@JohanMabille JohanMabille mentioned this pull request Jan 24, 2017
@JohanMabille
Copy link
Member

No problem, thank you for implementing this feature!

@JohanMabille JohanMabille merged commit 00caa70 into xtensor-stack:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants