Setup public headers #181
Merged
Setup public headers #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is complaining the PUBLIC_HEADER is not a whitelisted property for INTERFACE libraries. I don't understand why the problem is not occuring in the pybind11_json PR pybind/pybind11_json#13 |
|
Can you try to update minimal required version of cmake to 3.4.3? Not sure it will fix the issue, but it might be worth trying it. |
|
This seems to have been fixed in a recent version of cmake: |
|
It is working on Linux and windows (appveyor), but not on OS X or on Windows with azure. |
SylvainCorlay
force-pushed
the
setup-public-headers
branch
from
0b9ad68
to
1e253bf
Compare
|
OK, setting up the PUBLIC_HEADER property on an INTERFACE library is allowed since https://cmake.org/cmake/help/v3.15/release/3.15.html#properties |
|
@JohanMabille this is ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.