add a serialiser for xvariant to json #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhur-tandon
force-pushed
the
xvariant-serialiser
branch
3 times, most recently
from
12e6193
to
5290221
Compare
madhur-tandon
force-pushed
the
xvariant-serialiser
branch
from
5290221
to
80f7467
Compare
|
The errors are unrelated to this PR and occur on master. Merging. |
|
By the way, I don't think it makes sense to have a generic de-serializer from JSON to a variant. One needs to pick the actual concrete type. So this is good as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.