Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2017 #194

Merged
merged 1 commit into from Aug 6, 2020
Merged

VS 2017 #194

merged 1 commit into from Aug 6, 2020

Conversation

SylvainCorlay
Copy link
Member

Please check if your PR fulfills these requirements

  • The title and the commit message(s) are descriptive
  • Small commits made to fix your PR have been squashed to avoid history pollution
  • Tests have been added for new features or bug fixes
  • API of new functions and classes are documented
  • If you PR introduces backward incompatible changes, update the version number
    in include/xtl/xtl_config.hpp according to the following rules:
    • if XTL_VERSION_PATCH is already 0-dev, you have nothing to do
    • otherwise, set XTL_VERSION_PATCH to 0-dev and increase XTL_VERSION_MINOR by 1

@SylvainCorlay
Copy link
Member Author

@JohanMabille it seems that you fixed that issue earlier. I am not 100% sure I understand what is going on.

Moving to MSVC 2017 on appveyor fixes it, but not for clang-cl on azure.

The same issue is also coming up on xwidgets.

This may be due to the VS2017 migration of conda-forge. gtest was recently rebuild and the latest build may be using VS2017.

@SylvainCorlay SylvainCorlay merged commit 44d4532 into xtensor-stack:master Aug 6, 2020
@SylvainCorlay SylvainCorlay deleted the vs2017 branch August 6, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant