Merge pull request #4683 from Tyriar/tyriar/minor_cleanup

Remove unneeded comments, headless options
xtermjs · Aug 17, 2023 · 3b3b23a · 3b3b23a
2 parents 9d7b929 + 7b87447
commit 3b3b23a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 30 deletions.
diff --git a/src/browser/Terminal.ts b/src/browser/Terminal.ts
@@ -74,8 +74,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
 
   private _overviewRulerRenderer: OverviewRulerRenderer | undefined;
 
-  // private _visualBellTimer: number;
-
   public browser: IBrowser = Browser as any;
 
   private _customKeyEventHandler: CustomKeyEventHandler | undefined;
@@ -146,18 +144,6 @@ export class Terminal extends CoreTerminal implements ITerminal {
   private _onWillOpen = this.register(new EventEmitter<HTMLElement>());
   public get onWillOpen(): IEvent<HTMLElement> { return this._onWillOpen.event; }
 
-  /**
-   * Creates a new `Terminal` object.
-   *
-   * @param options An object containing a set of options, the available options are:
-   *   - `cursorBlink` (boolean): Whether the terminal cursor blinks
-   *   - `cols` (number): The number of columns of the terminal (horizontal size)
-   *   - `rows` (number): The number of rows of the terminal (vertical size)
-   *
-   * @public
-   * @class Xterm Xterm
-   * @alias module:xterm/src/xterm
-   */
   constructor(
     options: Partial<ITerminalOptions> = {}
   ) {

diff --git a/src/headless/Terminal.ts b/src/headless/Terminal.ts
@@ -25,13 +25,9 @@ import { DEFAULT_ATTR_DATA } from 'common/buffer/BufferLine';
 import { IBuffer } from 'common/buffer/Types';
 import { CoreTerminal } from 'common/CoreTerminal';
 import { EventEmitter, forwardEvent } from 'common/EventEmitter';
-import { ITerminalOptions as IInitializedTerminalOptions } from 'common/services/Services';
 import { IMarker, ITerminalOptions, ScrollSource } from 'common/Types';
 
 export class Terminal extends CoreTerminal {
-  // TODO: We should remove options once components adopt optionsService
-  public get options(): Required<IInitializedTerminalOptions> { return this.optionsService.options; }
-
   private readonly _onBell = this.register(new EventEmitter<void>());
   public readonly onBell = this._onBell.event;
   private readonly _onCursorMove = this.register(new EventEmitter<void>());
@@ -43,18 +39,6 @@ export class Terminal extends CoreTerminal {
   private readonly _onA11yTabEmitter = this.register(new EventEmitter<number>());
   public readonly onA11yTab = this._onA11yTabEmitter.event;
 
-  /**
-   * Creates a new `Terminal` object.
-   *
-   * @param options An object containing a set of options, the available options are:
-   *   - `cursorBlink` (boolean): Whether the terminal cursor blinks
-   *   - `cols` (number): The number of columns of the terminal (horizontal size)
-   *   - `rows` (number): The number of rows of the terminal (vertical size)
-   *
-   * @public
-   * @class Xterm Xterm
-   * @alias module:xterm/src/xterm
-   */
   constructor(
     options: ITerminalOptions = {}
   ) {