Merge pull request #2025 from thebradbain/fix-terminal-resize

Clear line cache on terminal resize
xtermjs · Apr 27, 2019 · 6237eaa · 6237eaa
2 parents c6f785f + 736bd53
commit 6237eaa
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/addons/search/SearchHelper.ts b/src/addons/search/SearchHelper.ts
@@ -21,6 +21,7 @@ export class SearchHelper implements ISearchHelper {
   private _linesCache: string[] = null;
   private _linesCacheTimeoutId = 0;
   private _cursorMoveListener: IDisposable | undefined;
+  private _resizeListener: IDisposable | undefined;
 
   constructor(private _terminal: ISearchAddonTerminal) {
     this._destroyLinesCache = this._destroyLinesCache.bind(this);
@@ -185,6 +186,7 @@ export class SearchHelper implements ISearchHelper {
     if (!this._linesCache) {
       this._linesCache = new Array(this._terminal._core.buffer.length);
       this._cursorMoveListener = this._terminal.onCursorMove(() => this._destroyLinesCache());
+      this._resizeListener = this._terminal.onResize(() => this._destroyLinesCache());
     }
 
     window.clearTimeout(this._linesCacheTimeoutId);
@@ -197,6 +199,10 @@ export class SearchHelper implements ISearchHelper {
       this._cursorMoveListener.dispose();
       this._cursorMoveListener = undefined;
     }
+    if (this._resizeListener) {
+      this._resizeListener.dispose();
+      this._resizeListener = undefined;
+    }
     if (this._linesCacheTimeoutId) {
       window.clearTimeout(this._linesCacheTimeoutId);
       this._linesCacheTimeoutId = 0;