Merge pull request #2348 from xtermjs/Tyriar-patch-1

Fix NPE on dispose when it hasn't been opened
xtermjs · Jul 25, 2019 · 689fb6b · 689fb6b
2 parents 26948f0 + 3dc5218
commit 689fb6b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/Terminal.ts b/src/Terminal.ts
@@ -270,7 +270,9 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp
       this._windowsMode.dispose();
       this._windowsMode = undefined;
     }
-    this._renderService.dispose();
+    if (this._renderService) {
+      this._renderService.dispose();
+    }
     this._customKeyEventHandler = null;
     this.write = () => {};
     if (this.element && this.element.parentNode) {