Improve publish dry run

xtermjs · Aug 19, 2023 · 8d7f42d · 8d7f42d
1 parent df1e7ed
commit 8d7f42d
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/bin/publish.js b/bin/publish.js
@@ -67,25 +67,24 @@ function checkAndPublishPackage(packageDir) {
   const packageJsonFile = path.join(packageDir, 'package.json');
   packageJson.version = nextVersion;
   console.log(`Set version of ${packageJsonFile} to ${nextVersion}`);
-  if (!isDryRun) {
-    fs.writeFileSync(packageJsonFile, JSON.stringify(packageJson, null, 2));
-  }
+  fs.writeFileSync(packageJsonFile, JSON.stringify(packageJson, null, 2));
 
   // Publish
   const args = ['publish'];
   if (!isStableRelease) {
     args.push('--tag', 'beta');
   }
+  if (isDryRun) {
+    args.push('--dry-run');
+  }
   console.log(`Spawn: npm ${args.join(' ')}`);
-  if (!isDryRun) {
-    const result = cp.spawnSync('npm', args, {
-      cwd: packageDir,
-      stdio: 'inherit'
-    });
-    if (result.status) {
-      console.error(`Spawn exited with code ${result.status}`);
-      process.exit(result.status);
-    }
+  const result = cp.spawnSync('npm', args, {
+    cwd: packageDir,
+    stdio: 'inherit'
+  });
+  if (result.status) {
+    console.error(`Spawn exited with code ${result.status}`);
+    process.exit(result.status);
   }
 
   console.groupEnd();