Merge pull request #4619 from Tyriar/tyriar/4611_2

Avoid using global document, add copyright
xtermjs · Jul 29, 2023 · ebdafe5 · ebdafe5
2 parents 17b8247 + a9662e8
commit ebdafe5
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/src/browser/renderer/dom/StyleSheet.ts b/src/browser/renderer/dom/StyleSheet.ts
@@ -1,15 +1,20 @@
+/**
+ * Copyright (c) 2023 The xterm.js authors. All rights reserved.
+ * @license MIT
+ */
+
 export interface IStyleSheet {
   dispose: () => void;
   setCss: (value: string) => void;
 }
 
-const createCssStyleSheet = (): IStyleSheet => {
+const createCssStyleSheet = (doc: Document): IStyleSheet => {
   const sheet = new CSSStyleSheet();
-  document.adoptedStyleSheets.push(sheet);
+  doc.adoptedStyleSheets.push(sheet);
   return {
     dispose() {
-      const index = document.adoptedStyleSheets.indexOf(sheet);
-      document.adoptedStyleSheets.splice(index, 1);
+      const index = doc.adoptedStyleSheets.indexOf(sheet);
+      doc.adoptedStyleSheets.splice(index, 1);
     },
     setCss(css) {
       sheet.replaceSync(css);
@@ -18,7 +23,8 @@ const createCssStyleSheet = (): IStyleSheet => {
 };
 
 const createStyleElement = (parent: HTMLElement): IStyleSheet => {
-  const element = document.createElement('style');
+  const doc = parent.ownerDocument;
+  const element = doc.createElement('style');
   parent.append(element);
   return {
     dispose() {
@@ -32,7 +38,7 @@ const createStyleElement = (parent: HTMLElement): IStyleSheet => {
 
 export const createStyle = (parent: HTMLElement): IStyleSheet => {
   try {
-    return createCssStyleSheet();
+    return createCssStyleSheet(parent.ownerDocument);
   } catch {
     return createStyleElement(parent);
   }