Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links are sometimes not applied #1025

Closed
Tyriar opened this issue Oct 4, 2017 · 2 comments
Closed

Links are sometimes not applied #1025

Tyriar opened this issue Oct 4, 2017 · 2 comments
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 4, 2017

VS Code issue microsoft/vscode#35552
@Tyriar Tyriar added the type/bug Something is misbehaving label Oct 4, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Oct 4, 2017
@Tyriar Tyriar self-assigned this Oct 4, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 4, 2017
@Tyriar
Fix links sometimes not getting applied
2a126cf 
There was an incorrect comparison which occasionally caused links to
not be picked up.

Fixes xtermjs#1025
@Tyriar Tyriar mentioned this issue Oct 4, 2017
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 6, 2017
@Tyriar
Fix links sometimes not getting applied
d8162d8 
There was an incorrect comparison which occasionally caused links to
not be picked up.

Fixes xtermjs#1025
@johnbendi
Copy link

I still get this issue at times. Even in the same terminal some links are clickable while some others are not. I don't even know where to start troubleshooting!

@Tyriar
Copy link
Member Author

Tyriar commented May 22, 2018

@johnbendi I've also seen it happen at least once, it seems like a different breakage and happens very rarely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@johnbendi @Tyriar