Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Scrolling Experience #1343

Closed
fkorotkov opened this issue Mar 20, 2018 · 4 comments · Fixed by #2388
Closed

Improve Scrolling Experience #1343

fkorotkov opened this issue Mar 20, 2018 · 4 comments · Fixed by #2388
Labels
help wanted type/bug Something is misbehaving
Milestone

Comments

@fkorotkov
Copy link

Right now Xterm.js captures all scroll events which leads to an inconvenient user experience in two related cases:

  1. When Xterm is small and a user scrolls to the very bottom and is trying to scroll more, nothing will happen. I would expect the whole page to continue scrolling once Xterm reaches the very bottom.

  2. When Xterm is large so there is no need for scrolling within Xterm. In this case Xterm captures all scrolling attempts and is stopping the whole page from scrolling. It's especially inconvenient if Xterm occupies most of the screen.

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2018

Seems reasonable, my use case for xterm.js is always a full screen app so there's no nested scrolling. It would be good to validate this won't cause issues if anyone watching this issue is using nested scroll bars.

@rlamana
Copy link

rlamana commented Dec 7, 2018

@Tyriar @pro-src The PR seems to be closed, what is the state of this? I am using xterm.js to showcase the features of our CLI tool. It is part of a longer page and this is a total blocker to push it to production. Any quick workarounds I can use for this? Thanks!

@Tyriar
Copy link
Member

Tyriar commented Dec 7, 2018

@rlamana there was a problem with the PR and it became stale, this is waiting on someone else in the community picking it up.

@ShahzadUmair
Copy link
Contributor

@Tyriar Faced a similar issue. I think i have a fix for this, opening a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants