Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bubbling scroll events to parent(s) #2388

Merged
merged 4 commits into from Aug 22, 2019

Conversation

ShahzadUmair
Copy link
Contributor

Fixes #1343

After this PR the scroll (touchmove/wheel) should bubble in case the scroll has reached the bottom or top of the viewport.

@Tyriar Tyriar added this to the 4.0.0 milestone Aug 22, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great, thanks 👌

@Tyriar Tyriar merged commit a67f57d into xtermjs:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Scrolling Experience
2 participants