Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Terminal.destroy #1371

Closed
Tyriar opened this issue Apr 4, 2018 · 2 comments · Fixed by #2155
Closed

Remove Terminal.destroy #1371

Tyriar opened this issue Apr 4, 2018 · 2 comments · Fixed by #2155
Assignees
Labels
breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 4, 2018

Let's standardize on dispose #1370

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Apr 4, 2018
@Tyriar Tyriar added this to the 4.0.0 milestone Apr 4, 2018
@Tyriar Tyriar self-assigned this Apr 4, 2018
@mofux
Copy link
Contributor

mofux commented Apr 6, 2018

The disposable pattern got a lot of traction recently with OSS like vscode and atom using this concept to track and release dependant resources. Basically, every object that has a dispose method is seen as a disposable. The creator of a disposable (usually also a disposable) can track it, and then dispose its dependencies once it gets disposed itself.

I would also like to change our own EventEmitter implementation to fully use this pattern, so destroy becomes dispose, and the on listener returns a disposable.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 7, 2018

👍 started in #1372

@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label May 11, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaks API and requires a major version bump type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants