Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing type annotations in demo/client.ts #1667

Closed
jerch opened this issue Sep 8, 2018 · 0 comments
Closed

missing type annotations in demo/client.ts #1667

jerch opened this issue Sep 8, 2018 · 0 comments
Labels
type/bug Something is misbehaving

Comments

@jerch
Copy link
Member

jerch commented Sep 8, 2018

In democlient.ts` there two type annotations missing:

xterm.js/demo/client.ts

Line 104 in bdb6647

regex: document.getElementById('regex').checked,

xterm.js/demo/client.ts

Line 115 in bdb6647

regex: document.getElementById('regex').checked,

webpack still bundles it correctly, but with ugly errors. Fixable by annotating it explicitly:

(document.getElementById('regex') as HTMLInputElement).checked
@jerch jerch added the type/bug Something is misbehaving label Sep 8, 2018
jerch added a commit to jerch/xterm.js that referenced this issue Sep 8, 2018
@jerch
fixes xtermjs#1667
4eede85
@jerch jerch mentioned this issue Sep 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jerch