Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IE hacks #1889

Closed
Tyriar opened this issue Jan 7, 2019 · 2 comments · Fixed by #2216
Closed

Remove IE hacks #1889

Tyriar opened this issue Jan 7, 2019 · 2 comments · Fixed by #2216
Assignees
@Tyriar
Labels
breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding
Milestone
4.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 7, 2019

I think it's about time to drop IE11 support, let's get rid of it when we ship v4
@Tyriar Tyriar added the type/proposal A proposal that needs some discussion before proceeding label Jan 7, 2019
@Tyriar Tyriar added this to the 4.0.0 milestone Jan 7, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Mar 23, 2019

As part of this I think we can always position the input textarea on the cursor which should fix issues like this microsoft/vscode#70823 (comment)

@Tyriar Tyriar mentioned this issue Mar 23, 2019
Closed
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label May 11, 2019
@Tyriar Tyriar mentioned this issue May 21, 2019
Closed
@Tyriar Tyriar mentioned this issue May 30, 2019
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 9, 2019
@Tyriar
Remove support for IE11
74e673c 
Fixes xtermjs#1889
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jun 9, 2019
@Tyriar
Remove support for IE11
02868c1 
Fixes xtermjs#1889
@Tyriar Tyriar mentioned this issue Jun 9, 2019
Merged
@Tyriar Tyriar self-assigned this Jun 9, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jun 10, 2019

I loosened by stance on this a little, the terminal works just fine in IE11 and the hacks we had appear to be for older versions of IE, so in #2216 I'm changing the wording to be "partial support" and clarifying what I mean.

@Tyriar Tyriar changed the title Drop IE11 support Remove IE hacks Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Partially support IE11 Tyriar/xterm.js
1 participant
@Tyriar