Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated patch release publishing doesn't work #2154

Closed
Tyriar opened this issue May 31, 2019 · 1 comment · Fixed by #2481
Closed

Automated patch release publishing doesn't work #2154

Tyriar opened this issue May 31, 2019 · 1 comment · Fixed by #2481
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
4.2.0

Comments

@Tyriar
Copy link
Member

Tyriar commented May 31, 2019

eq() doesn't support regex

Screen Shot 2019-05-31 at 9 38 52 AM
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label May 31, 2019
@Tyriar Tyriar self-assigned this May 31, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jun 4, 2019

I think the right fix here might be to allow specifying the release name for cases like this, this would also allow one off builds when needed for example if vscode needed a patch on an older commit (eg. 3.14.2-vscode1).

@Tyriar Tyriar added this to the 4.2.0 milestone Oct 7, 2019
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 17, 2019
@Tyriar
Allow builds to specify a force release var
990be06 
This will let us automate patch releases by queuing a manual build

Fixes xtermjs#2154
@Tyriar Tyriar mentioned this issue Oct 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

Allow builds to specify a force release var Tyriar/xterm.js
1 participant
@Tyriar