Improve .npmignore of xterm-addon-search

[aeschli]

You can see from
https://unpkg.com/browse/xterm-addon-search@0.7.0/

that the xterm-addon-search npm packages contains unnecessary resources:

• fixtures
• out
• src (lib/xterm-addon-search.js.map already contains sources)

[aeschli]

Same for https://unpkg.com/browse/xterm-addon-unicode11@0.2.0/ and https://unpkg.com/browse/xterm-addon-webgl@0.9.0/

Also

• out-test (https://unpkg.com/browse/xterm-addon-unicode11@0.3.0-beta.3/)

[jerch]

Partly also covered by the issue #3137. Guess we should clarify, what we want to end up in packages for whatever reason and exclude everything else.

[kumaran-14]

I would like to take on this and related #3137
What would be the solution to this?

[Tyriar]

@kumaran-14 the solution for these is to make the .npmignore for the various modules (addons+code for #3137) exclude files that we should not be shipping inside the modules. You might want to read up about how .npmignore works before jumping in - it's similar to .gitignore.

[jerch]

Had another look into this - it seems our addon packages are stuck between source distribution - nodejs target - browser prebundled, we kinda have abit of everything but nothing to proper full extend 😸

Not sure where to go from here, a few thoughts are:

• A source package distribution never gonna work to full extend with addon packages due their entanglement with the base repo. Furthermore full source can also be obtain from the repo itself, so src is not that useful.
• If we want to go with one npm package only, we prolly should move browser builds to dist and let main point to the addon entry file (addon class). This would be my preferred variant, it is just moving current content abit around.
• If we want browser builds to be distributed via npm, we should do a second package with main pointing to an ES6 module bundle of the addon. Those will not work in nodejs out-of-the-box, but the browser will be more than happy.

[mofux]

If we want browser builds to be distributed via npm, we should do a second package with main pointing to an ES6 module bundle of the addon. Those will not work in nodejs out-of-the-box, but the browser will be more than happy.

AFAIK we could use themodule field in package.json to point to the entry file of the ES6 Module bundle. The main should still point to the CJS version.

[jerch]

To solve the build target ambiguity, there is a new package.json entry exports since nodejs v12 (see here for an introduction). With this we can distribute ES6 builds together with default nodejs build (commonjs) in just one package. It is even possible to put an IIFE build as third goodie in the package so old style non ES6 script tags still work.