Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum contrast ratio isn't working for inverted text in DOM renderer #3846

Closed
Tyriar opened this issue Jun 1, 2022 · 2 comments · Fixed by #3849
Closed

Minimum contrast ratio isn't working for inverted text in DOM renderer #3846

Tyriar opened this issue Jun 1, 2022 · 2 comments · Fixed by #3849
Assignees
@meganrogge
Labels
area/accessibility area/renderer-dom type/bug Something is misbehaving
Milestone
4.19.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022

minimumContrastRatio = 4.5:

image

minimumContrastRatio = 9:

image
@Tyriar Tyriar added this to the 4.19.0 milestone Jun 1, 2022
@Tyriar Tyriar mentioned this issue Jun 1, 2022
Closed
@meganrogge
Copy link
Member

Dom:
Screen Shot 2022-06-01 at 2 39 30 PM

Webgl:
Screen Shot 2022-06-01 at 2 39 10 PM

@meganrogge
Copy link
Member

meganrogge commented Jun 1, 2022 •
edited

bgL is calculated to be 0 for DOM

xterm.js/src/common/Color.ts

Lines 167 to 168 in de03391

const bgL = rgb.relativeLuminance(bgRgba >> 8);
const fgL = rgb.relativeLuminance(fgRgba >> 8);

Screen Shot 2022-06-01 at 2 42 09 PM

vs webgl
Screen Shot 2022-06-01 at 2 43 02 PM

meganrogge added a commit to meganrogge/xterm.js that referenced this issue Jun 2, 2022
@meganrogge @Tyriar
fix xtermjs#3846
b4a1071 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge meganrogge mentioned this issue Jun 2, 2022
Merged
meganrogge added a commit that referenced this issue Jun 2, 2022
@meganrogge @Tyriar
fix #3846 (#3849)
bc9c9dd 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
area/accessibility area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

resolve bg color for each color mode in the dom renderer meganrogge/xterm.js
2 participants
@Tyriar @meganrogge